Skip to content

feat(i18n): add lazy loading for remirror and dayjs translations#17877

Open
v-tarasevich-blitz-brain wants to merge 2 commits into
masterfrom
vt--cat-2424--add-lazy-loading
Open

feat(i18n): add lazy loading for remirror and dayjs translations#17877
v-tarasevich-blitz-brain wants to merge 2 commits into
masterfrom
vt--cat-2424--add-lazy-loading

Conversation

@v-tarasevich-blitz-brain

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This PR adds lazy loading for remirror and dayjs translations

Depends on #17874

@github-actions github-actions Bot added the product PR or Issue related to the DataHub UI/UX label Jun 12, 2026
@alwaysmeticulous

alwaysmeticulous Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Meticulous spotted 0 visual differences across 1462 screens tested: view results.

Meticulous evaluated ~10 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit 4b72376 feat(i18n): add lazy loading for remirror and dayjs translations. This comment will update as new commits are pushed.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 323.24kB (1.34%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 24.53MB 323.24kB (1.34%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -5.1kB 8.93MB -0.06%
assets/de-*.js -300.02kB 1.77kB -99.41%
assets/de-*.js (New) 8.37kB 8.37kB 100.0% 🚀
assets/de-*.js (New) 301.79kB 301.79kB 100.0% 🚀
assets/es-*.js (New) 298.5kB 298.5kB 100.0% 🚀
assets/es-*.js (New) 1.5kB 1.5kB 100.0% 🚀
assets/es-*.js (New) 8.38kB 8.38kB 100.0% 🚀
assets/pt-*.js -284.97kB 8.29kB -97.17%
assets/pt-*.js (New) 1.53kB 1.53kB 100.0% 🚀
assets/pt-*.js (New) 293.26kB 293.26kB 100.0% 🚀

Files in assets/index-*.js:

  • ./src/app/i18n/constants.ts → Total Size: 739 bytes

  • ./src/app/i18n/hooks/useChangeLocale.ts → Total Size: 538 bytes

  • ./src/app/i18n/hooks/useLanguageSync.ts → Total Size: 240 bytes

  • ./src/alchemy-components/components/Editor/RemirrorLocaleProvider.tsx → Total Size: 1.19kB

Files in assets/es-*.js:

  • ./src/i18n/locales/es/entity.identity.json → Total Size: 10.78kB

  • ./src/i18n/locales/es/entity.profile.incident.json → Total Size: 5.39kB

  • ./src/i18n/locales/es/entity.profile.stats.json → Total Size: 7.1kB

  • ./src/i18n/locales/es/entity.profile.editor.json → Total Size: 885 bytes

  • ./src/i18n/locales/es/entity.preview.json → Total Size: 4.73kB

  • ./src/i18n/locales/es/entity.profile.queries.json → Total Size: 2.39kB

  • ./src/i18n/locales/es/entity.profile.summary.json → Total Size: 1.67kB

  • ./src/i18n/locales/es/common.labels.json → Total Size: 974 bytes

  • ./src/i18n/locales/es/entity.profile.schema.json → Total Size: 10.75kB

  • ./src/i18n/locales/es/entity.profile.documentation.json → Total Size: 1.93kB

  • ./src/i18n/locales/es/common.counts.json → Total Size: 907 bytes

  • ./src/i18n/locales/es/analytics.json → Total Size: 743 bytes

  • ./src/i18n/locales/es/entity.profile.tests.json → Total Size: 703 bytes

  • ./src/i18n/locales/es/alchemy.json → Total Size: 3.93kB

  • ./src/i18n/locales/es/common.actions.json → Total Size: 3.27kB

  • ./src/i18n/locales/es/entity.profile.tabs.json → Total Size: 4.72kB

  • ./src/i18n/locales/es/common.feedback.json → Total Size: 591 bytes

  • ./src/i18n/locales/es/auth.json → Total Size: 1.86kB

  • ./src/i18n/locales/es/entity.ownership.json → Total Size: 1.73kB

  • ./src/i18n/locales/es/entity.profile.access.json → Total Size: 548 bytes

  • ./src/i18n/locales/es/entity.form.json → Total Size: 2.65kB

@codecov

codecov Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@maggiehays maggiehays added the needs-review Label for PRs that need review from a maintainer. label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-tarasevich-blitz-brain @maggiehays